Generate ibc proto with buf #2199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [prost](https://github.com/tokio-rs/prost) from 0.9.0 to 0.10.1. - [Release notes](https://github.com/tokio-rs/prost/releases) - [Commits](tokio-rs/prost@v0.9.0...v0.10.1) --- updated-dependencies: - dependency-name: prost dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Fix the naming conflict in generated proto files caused by tokio-rs/prost#505
Version 0.7.1 was yanked
Use buf.gen.yaml to specify protoc-gen-prost as the code generation plugin. Unsolved problems: - Still need to manually synchronize checkouts of cosmos-sdk and ibc-go. - ibc.mock falls out because we can't make a dependency on ibc-go, as it is not published on BSR. - Can't just generate off any commit from the proto source repositories, buf seems to only find ones on the default branch?
mzabaluev
added
A: help-wanted
3 tasks
|
Superseded by #2213. This can be resurrected later when upstream buf modules are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to switch to buf and protoc-gen-prost for generating protobuf data structures in
ibc_proto. As both cosmos-sdk and ibc-go already use buf, it's a way to piggyback on dependency management in the upstreambuf.yamlfiles, rather than try to follow the intricacies of third-party vendoring locally.Includes #2161.
Unresolved problems
as it is not published on BSR. Publish the proto module on BSR cosmos/ibc-go#1345
buf seems to only look on the default branch?
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.