-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to prost 0.10 and tonic 0.7 #2161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [prost](https://github.com/tokio-rs/prost) from 0.9.0 to 0.10.1. - [Release notes](https://github.com/tokio-rs/prost/releases) - [Commits](tokio-rs/prost@v0.9.0...v0.10.1) --- updated-dependencies: - dependency-name: prost dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Due to changes in prost, some protobuf-generated code fails to compile, likely needing overrides. |
mzabaluev
commented
Apr 28, 2022
Like #2100, |
Fix the naming conflict in generated proto files caused by tokio-rs/prost#505
mzabaluev
commented
May 3, 2022
romac
reviewed
May 3, 2022
romac
reviewed
May 3, 2022
mzabaluev
requested review from
seanchen1991,
soareschen,
hu55a1n1 and
plafer
as code owners
May 6, 2022 07:41
Version 0.7.1 was yanked
seanchen1991
approved these changes
May 9, 2022
adizere
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a quick look, looks good!
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Bump prost from 0.9.0 to 0.10.1 Bumps [prost](https://github.com/tokio-rs/prost) from 0.9.0 to 0.10.1. - [Release notes](https://github.com/tokio-rs/prost/releases) - [Commits](tokio-rs/prost@v0.9.0...v0.10.1) --- updated-dependencies: - dependency-name: prost dependency-type: direct:production update-type: version-update:semver-minor ... * Harmonize & cleanup tonic + prost deps. * Update tonic to 0.7 * Update tendermint to 0.23.7 * Regenerate proto sources and re-apply manual post-generation hacks. * Pin ics23 to 0.8.0-alpha Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adi Seredinschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rolls up a bunch of dependency updates and code regeneration for the gRPC/protobuf stack.
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.