Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prost 0.10 and tonic 0.7 #2161

Merged
merged 16 commits into from
May 10, 2022
Merged

Update to prost 0.10 and tonic 0.7 #2161

merged 16 commits into from
May 10, 2022

Conversation

mzabaluev
Copy link
Contributor

Description

Rolls up a bunch of dependency updates and code regeneration for the gRPC/protobuf stack.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

dependabot bot and others added 4 commits April 19, 2022 21:45
Bumps [prost](https://github.com/tokio-rs/prost) from 0.9.0 to 0.10.1.
- [Release notes](https://github.com/tokio-rs/prost/releases)
- [Commits](tokio-rs/prost@v0.9.0...v0.10.1)

---
updated-dependencies:
- dependency-name: prost
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mzabaluev mzabaluev added the I: dependencies Internal: related to dependencies label Apr 28, 2022
@mzabaluev
Copy link
Contributor Author

Due to changes in prost, some protobuf-generated code fails to compile, likely needing overrides.

@mzabaluev
Copy link
Contributor Author

mzabaluev commented May 2, 2022

Like #2100, this is blocked by cosmos/ics23#84

@mzabaluev mzabaluev marked this pull request as ready for review May 3, 2022 08:25
Cargo.toml Outdated Show resolved Hide resolved
Version 0.7.1 was yanked
@mzabaluev mzabaluev mentioned this pull request May 9, 2022
9 tasks
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look, looks good!

@mzabaluev mzabaluev merged commit 57e3348 into master May 10, 2022
@mzabaluev mzabaluev deleted the mikhail/prost-0.10 branch May 10, 2022 07:27
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Bump prost from 0.9.0 to 0.10.1

Bumps [prost](https://github.com/tokio-rs/prost) from 0.9.0 to 0.10.1.
- [Release notes](https://github.com/tokio-rs/prost/releases)
- [Commits](tokio-rs/prost@v0.9.0...v0.10.1)

---
updated-dependencies:
- dependency-name: prost
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

* Harmonize & cleanup tonic + prost deps.

* Update tonic to 0.7

* Update tendermint to 0.23.7

* Regenerate proto sources and re-apply manual post-generation hacks.

* Pin ics23 to 0.8.0-alpha

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adi Seredinschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants