Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some error messages are not precise enough #934

Closed
5 tasks done
romac opened this issue May 12, 2021 · 0 comments · Fixed by #935
Closed
5 tasks done

Some error messages are not precise enough #934

romac opened this issue May 12, 2021 · 0 comments · Fixed by #935
Assignees
Labels
O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@romac
Copy link
Member

romac commented May 12, 2021

Crate

relayer, relayer-cli

Summary of Bug

Some error message are not precise enough, eg:

$ hermes create channel consensus-testnet consensus-testnet2 --port-a transfer --port-b transfer 
May 12 10:18:07.852  INFO ibc_relayer_cli::commands: Using default configuration from: '.hermes/config.toml'
May 12 10:18:07.948 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'Tx'
May 12 10:18:07.969 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'NewBlock'
May 12 10:18:07.988 DEBUG ibc_relayer::event::monitor: subscribed to all queries
May 12 10:18:07.988  INFO ibc_relayer::event::monitor: starting event monitor chain.id=consensus-testnet
Error: chain runtime/handle error: Event monitor
$ hermes create channel consensus-testnet consensus-testnet2 --port-a transfer --port-b transfer
May 12 10:34:10.108  INFO ibc_relayer_cli::commands: Using default configuration from: '.hermes/config.toml'
May 12 10:34:10.209 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'Tx'
May 12 10:34:10.230 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'NewBlock'
May 12 10:34:10.253 DEBUG ibc_relayer::event::monitor: subscribed to all queries
May 12 10:34:10.253  INFO ibc_relayer::event::monitor: starting event monitor chain.id=consensus-testnet
May 12 10:34:10.342 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'Tx'
May 12 10:34:10.371 DEBUG ibc_relayer::event::monitor: subscribing to query: tm.event = 'NewBlock'
May 12 10:34:10.406 DEBUG ibc_relayer::event::monitor: subscribed to all queries
May 12 10:34:10.406  INFO ibc_relayer::event::monitor: starting event monitor chain.id=consensus-testnet2
May 12 10:34:10.406  INFO ibc_relayer_cli::commands::create::channel: Creating new clients, new connection, and a new channel with order ORDER_UNORDERED
Error: error raised while creating client: cannot extract client_id from result

Version

v0.3.0

Steps to Reproduce

TBD

Acceptance Criteria

The error messages provide more information to the user to help them diagnose the underlying issue.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added the O: new-feature Objective: cause to add a new feature or support label May 12, 2021
@romac romac added this to the 05.2021 milestone May 12, 2021
@romac romac self-assigned this May 12, 2021
@romac romac mentioned this issue May 12, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant