Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk upgrade CLI #763

Closed
3 of 8 tasks
adizere opened this issue Mar 24, 2021 · 0 comments · Fixed by #1077
Closed
3 of 8 tasks

Add bulk upgrade CLI #763

adizere opened this issue Mar 24, 2021 · 0 comments · Fixed by #1077
Assignees
Labels
A: good-first-issue Admin: good for newcomers I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@adizere
Copy link
Member

adizere commented Mar 24, 2021

Crate

ibc-relayer-cli

Summary

The upgrade CLI (introduced in informalsystems/ibc-rs#723) expects as argument the identifier of a specific client which to upgrade. It would be beneficial to permit upgrading all IBC clients hosted on the same chain and targeting the same chain (instead of forcing upgrades to work on a discrete client-by-client basis).

Proposal

For instance,

hermes tx raw upgrade-client DST-CHAIN SRC-CHAIN

will upgrade all clients hosted on DST-CHAIN that verify headers for the upgraded SRC-CHAIN.

Tasks:

  • modify the upgrade CLI to have optional client identifier parameter; if this parameter is missing, then perform bulk upgrade of all found clients
  • update ADR 006 to include the upgrade client command, which would be similar to the create client and update client commands (see ADR 006#clients)
  • consider retiring the tx raw upgrade-client command in favor of upgrade client

Original comment from PR review

I think we should make dst_client_id optional and if not entered to upgrade all clients of src_chain_id present on dst_chain_id. The way it is, with a lot of clients, the user needs to query all clients and issue the upgrade for each client.
Also, we should have a hermes client upgrade.. command in place of or in addition to this command.

Originally posted by @ancazamfir in informalsystems/ibc-rs#723 (comment)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: cause to add a new feature or support A: good-first-issue Admin: good for newcomers I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Mar 24, 2021
@adizere adizere added this to the 04.2021 milestone Mar 24, 2021
@adizere adizere modified the milestones: 04.2021, 06.2021 Apr 27, 2021
@ancazamfir ancazamfir modified the milestones: 06.2021, 07.2021 May 25, 2021
@hu55a1n1 hu55a1n1 mentioned this issue Jun 11, 2021
5 tasks
@hu55a1n1 hu55a1n1 self-assigned this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers I: CLI Internal: related to the relayer's CLI I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants