Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the client_def.rs file in state, consensus, header, etc #740

Closed
5 tasks done
ancazamfir opened this issue Mar 11, 2021 · 0 comments · Fixed by #741
Closed
5 tasks done

Split the client_def.rs file in state, consensus, header, etc #740

ancazamfir opened this issue Mar 11, 2021 · 0 comments · Fixed by #741
Assignees
@ancazamfir
Labels
O: code-hygiene Objective: cause to improve code hygiene
Milestone
03.2021

Comments

@ancazamfir
Copy link
Collaborator

Crate

modules

Summary

The client_def.rs file is currently hundred lines of code and more will be added as part of #691.

Problem Definition

Proposal

Pull out the client state, consensus, header in separate modules.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added the O: code-hygiene Objective: cause to improve code hygiene label Mar 11, 2021
@ancazamfir ancazamfir added this to the 03.2021 milestone Mar 11, 2021
@ancazamfir ancazamfir self-assigned this Mar 11, 2021
@ancazamfir ancazamfir mentioned this issue Mar 11, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancazamfir ancazamfir

Labels
O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Milestone
03.2021
Development

Successfully merging a pull request may close this issue.

Split client_def.rs in client_state, client_consensus, header informalsystems/hermes
1 participant
@ancazamfir