Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 003 update to reflect recent changes around Events #548

Closed
5 tasks done
adizere opened this issue Jan 25, 2021 · 0 comments · Fixed by #497
Closed
5 tasks done

ADR 003 update to reflect recent changes around Events #548

adizere opened this issue Jan 25, 2021 · 0 comments · Fixed by #497
Assignees
@adizere
Labels
I: documentation Internal: improvements or additions to documentation
Milestone
03.2021

Comments

@adizere
Copy link
Member

adizere commented Jan 25, 2021

Crate

no crate, just docs

Summary

I suggest we do a follow-up PR to update ADR003 events section, making it clear that handlers are using the strongly-typed events, not these loosely-typed events.

Originally posted by @adizere in #535 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added the I: documentation Internal: improvements or additions to documentation label Jan 25, 2021
@adizere adizere added this to the v0.1.1 milestone Jan 25, 2021
@adizere adizere self-assigned this Jan 25, 2021
@adizere adizere mentioned this issue Feb 12, 2021
Merged
5 tasks
@adizere adizere modified the milestones: v0.1.1, 03.2021 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
I: documentation Internal: improvements or additions to documentation
Projects
None yet
Milestone
03.2021
Development

Successfully merging a pull request may close this issue.

ADR 005 & ADR 003 update informalsystems/hermes
1 participant
@adizere