Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metrics for ICS29 fees #3090

Closed
5 tasks
Tracked by #2788
ljoss17 opened this issue Feb 16, 2023 · 0 comments · Fixed by #3149
Closed
5 tasks
Tracked by #2788

Improve metrics for ICS29 fees #3090

ljoss17 opened this issue Feb 16, 2023 · 0 comments · Fixed by #3149
Assignees
@ljoss17
Labels
I: telemetry Internal: related to Telemetry & metrics O: ics29-fee Objective: Fee middleware support
Milestone
v1.4

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Feb 16, 2023

Summary

Some additional metrics for ICS29 fees would be helpful to track the amounts being paid through this mechanism.

Problem Definition

There are no easy ways for operators to observe the impact of ICS29 fees at the moment.

Proposal

Some features which could potentially be useful are:

  • Total amount paid to specific wallets by chain
  • Being able to filter which addresses are displayed in the metrics
  • Showing the amount received the past X days

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 self-assigned this Feb 16, 2023
@ljoss17 ljoss17 added I: telemetry Internal: related to Telemetry & metrics O: ics29-fee Objective: Fee middleware support labels Feb 16, 2023
@seanchen1991 seanchen1991 mentioned this issue Feb 21, 2023
Closed
9 tasks
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Feb 21, 2023
@seanchen1991 seanchen1991 added this to the v1.4 milestone Feb 21, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes Feb 21, 2023
@ljoss17 ljoss17 mentioned this issue Mar 8, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in Hermes Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
I: telemetry Internal: related to Telemetry & metrics O: ics29-fee Objective: Fee middleware support
Projects
Hermes
Status: ✅ Done
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Improve ICS29 fee distribution metrics informalsystems/hermes
2 participants
@seanchen1991 @ljoss17