Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error output when upgrading client with hermes upgrade client #2781

Closed
1 of 7 tasks
ljoss17 opened this issue Oct 28, 2022 · 2 comments · Fixed by #2795
Closed
1 of 7 tasks

Error output when upgrading client with hermes upgrade client #2781

ljoss17 opened this issue Oct 28, 2022 · 2 comments · Fixed by #2795
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Oct 28, 2022

Summary of Bug

There is an issue with the hermes upgrade client which seems to be related to the Any types.

Error output:

ERROR failed while trying to upgrade client id 07-tendermint-0 for chain ibc-0: failed while fetching from
chain the upgraded client state: conversion from a protobuf `Any` into a domain type failed: conversion
from a protobuf `Any` into a domain type failed:
error converting message type into domain type: the client state was not found

Version

master branch 28.10.22, hermes 1.0.0+3aba0ff27

Steps to Reproduce

Follow the guide to upgrade the chain, https://hermes.informal.systems/commands/upgrade/test.html.
Note that the command at step 2. should actually be: hermes tx upgrade-chain --reference-chain ibc-0 --host-chain ibc-1 --host-client 07-tendermint-0 --amount 10000000 --height-offset 60

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the v1.2 milestone Oct 31, 2022
@adizere adizere added P-medium A: bug Admin: something isn't working labels Oct 31, 2022
@plafer
Copy link
Contributor

plafer commented Nov 2, 2022

just tried it with the latest master and it worked

SUCCESS [
    UpdateClient(
        UpdateClient {
            common: Attributes {
                client_id: ClientId(
                    "07-tendermint-0",
                ),
                client_type: Tendermint,
                consensus_height: Height {
                    revision: 0,
                    height: 80,
                },
            },
            header: Some(
                 Header {...},
            ),
        },
    ),
    UpgradeClient(
        UpgradeClient(
            Attributes {
                client_id: ClientId(
                    "07-tendermint-0",
                ),
                client_type: Tendermint,
                consensus_height: Height {
                    revision: 0,
                    height: 81,
                },
            },
        ),
    ),
]

@ljoss17
Copy link
Contributor Author

ljoss17 commented Nov 2, 2022

It seems that this error is triggered when calling hermes upgrade client --host-chain ibc-1 --client 07-tendermint-0 --upgrade-height <UPGRADE_HEIGHT> with the incorrect UPGRADE_HEIGHT.
Otherwise, if the correct UPGRADE_HEIGHT is passed, everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants