Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending N messages to a chain does not always return N responses #2333

Closed
5 tasks
ancazamfir opened this issue Jun 24, 2022 · 0 comments · Fixed by #2334
Closed
5 tasks

Sending N messages to a chain does not always return N responses #2333

ancazamfir opened this issue Jun 24, 2022 · 0 comments · Fixed by #2334
Assignees
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Summary of Bug

When hermes submits N messages to a chain it should get back N responses. This is currently broken when Tx errors occur.

When the messages are sent to cosmos-sdk, they may be split in M transactions. If one of the Tx-es fails all messages are considered failed (the index in the error indicates the position of the message that caused the failure). The Tx failure should recorded for all its messages.

Version

master

Steps to Reproduce

  • start two chains
  • create channel
  • send N transactions making sure max_msg_num is smaller than N
    (tested with max_msg_num = 5 and send N=15).
  • there may be other ways to cause the error, i used the ft-transfer with a big amount such that the wallet is drained at some message x, x > max_msg_num
    (tested with wallet that has 100M samoleans and sent 15 transfers of 9M each)
  • the output should show N results

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the v1.0.0 milestone Jun 24, 2022
@adizere adizere moved this to Backlog in IBC-rs: the road to v1 Jun 24, 2022
Repository owner moved this from Backlog to Closed in IBC-rs: the road to v1 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants