Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to skip interactive prompt in Hermes create channel CLI #2317

Closed
4 of 6 tasks
adizere opened this issue Jun 20, 2022 · 0 comments · Fixed by #2316
Closed
4 of 6 tasks

Add ability to skip interactive prompt in Hermes create channel CLI #2317

adizere opened this issue Jun 20, 2022 · 0 comments · Fixed by #2316
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
v1.0.0

Comments

@adizere
Copy link
Member

adizere commented Jun 20, 2022 •
edited by romac
Loading

Summary

Add flag to skip interactive confirmation as part of create channel --new-client-connection CLI.

Problem Definition

Follow-up to #1421.

Feedback from user on the PR directly:

This PR adds a --yes flag to skip the --new-client-connection confirmation in the hermes create channel command. The motivation behinds this addition is that the --new-client-connection flag comes quite handy in testing environments as it allows to create new clients/connection instantly but bypassing the confirmation proved to be quite difficult. I tried to bypass it with different variations from the shell script (i.e. yes | hermes create and echo 'y' | hermes create) but eventually none of them worked.

Acceptance Criteria

  • Add --yes to skip interactive prompt as part of create channel --new-client-connection CLI

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: cause to add a new feature or support I: CLI Internal: related to the relayer's CLI O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Jun 20, 2022
@adizere adizere added this to the v1.0.0 milestone Jun 20, 2022
@adizere adizere linked a pull request Jun 20, 2022 that will close this issue
feat: add flag to skip new_client_connection confirmation #2316
Merged
6 tasks
@adizere adizere moved this to Backlog in IBC-rs: the road to v1 Jun 20, 2022
@adizere adizere moved this from Backlog to Needs Review in IBC-rs: the road to v1 Jun 20, 2022
@adizere adizere mentioned this issue Jun 20, 2022
Merged
6 tasks
Repository owner moved this from Needs Review to Closed in IBC-rs: the road to v1 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: CLI Internal: related to the relayer's CLI O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
IBC-rs: the road to v1
Status: Closed
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

feat: add flag to skip new_client_connection confirmation InjectiveLabs/ibc-rs
1 participant
@adizere