Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Uninitialized state from connection #217

Closed
4 tasks
adizere opened this issue Sep 2, 2020 · 3 comments · Fixed by #312
Closed
4 tasks

Remove Uninitialized state from connection #217

adizere opened this issue Sep 2, 2020 · 3 comments · Fixed by #312
Labels
A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers I: spec Internal: related to IBC specifications
Milestone
v0.0.4

Comments

@adizere
Copy link
Member

adizere commented Sep 2, 2020

Summary of Bug

We should align with the ICSes.

@adizere Is there a particular reason the Rust implementation uses the Unitialized state?
If not, I suggest we remove it and likewise in the SDK (see above comment) to match the specification, then close this issue.

Originally posted by @cwgoes in cosmos/ibc#452 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers I: spec Internal: related to IBC specifications connection labels Sep 2, 2020
@adizere adizere added this to the v0.0.5 milestone Sep 2, 2020
@ancazamfir
Copy link
Collaborator

We should wait for the protobuf change in SDK before we proceed with this.

@cwgoes
Copy link

cwgoes commented Sep 3, 2020

For reference, the SDK issue tracking this work is cosmos/cosmos-sdk#7175.

@ancazamfir ancazamfir mentioned this issue Oct 15, 2020
Merged
6 tasks
@ancazamfir ancazamfir changed the title Remove Uninitialized state from connection and channel Remove Uninitialized state from connection Oct 15, 2020
@ancazamfir
Copy link
Collaborator

Channel messages need a significant rework and cleanup (#315 ) and the change for the channel state will be done there.

@adizere adizere modified the milestones: v0.0.5, v0.0.4 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers I: spec Internal: related to IBC specifications
Projects
None yet
Milestone
v0.0.4
Development

Successfully merging a pull request may close this issue.

Remove Uninitialized from connection state informalsystems/hermes
3 participants
@adizere @ancazamfir @cwgoes