Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Interchain accounts filtering policy #1927

Closed
adizere opened this issue Mar 1, 2022 · 1 comment · Fixed by #1931
Closed

Support for Interchain accounts filtering policy #1927

adizere opened this issue Mar 1, 2022 · 1 comment · Fixed by #1931
Assignees
Labels
I: CLI Internal: related to the relayer's CLI I: configuration Internal: related to Hermes configuration O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@adizere
Copy link
Member

adizere commented Mar 1, 2022

We should add an option in the mode.packets or chain section of config.toml that toggles on/off relaying of packets that are related to Interchain accounts.

Update:

This has been implemented by adding support for wildcards in the packet filter config, eg. to only relay on channel-0 and on all ICA channels:

[chains.packet_filter]
policy = 'allow'
list = [
  ['ica*', '*'],
  ['transfer', 'channel-0'],
]
@adizere adizere added this to the v0.13.0 milestone Mar 1, 2022
@adizere adizere added I: CLI Internal: related to the relayer's CLI I: configuration Internal: related to Hermes configuration O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product P-critical labels Mar 1, 2022
@romac romac self-assigned this Mar 1, 2022
@adizere adizere moved this from Needs PR to Needs Review in IBC-rs: the road to v1 Mar 7, 2022
@romac romac mentioned this issue Mar 22, 2022
1 task
@romac
Copy link
Member

romac commented Mar 22, 2022

This has been implemented by adding support for wildcards in the packet filter config, eg. to only relay on channel-0 and on all ICA channels:

[chains.packet_filter]
policy = 'allow'
list = [
  ['ica*', '*'],
  ['transfer', 'channel-0'],
]

Repository owner moved this from Needs Review to Closed in IBC-rs: the road to v1 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: CLI Internal: related to the relayer's CLI I: configuration Internal: related to Hermes configuration O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
No open projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants