Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection delay period is checked against relayer's local time #1772

Closed
5 tasks
Tracked by #1836
hu55a1n1 opened this issue Jan 14, 2022 · 0 comments · Fixed by #1917
Closed
5 tasks
Tracked by #1836

Connection delay period is checked against relayer's local time #1772

hu55a1n1 opened this issue Jan 14, 2022 · 0 comments · Fixed by #1917
Assignees
@hu55a1n1
Labels
A: bug Admin: something isn't working I: logic Internal: related to the relaying logic
Milestone
v0.14.0

Comments

@hu55a1n1
Copy link
Member

Crate

relayer

Summary of Bug

The relayer logic that implements connection delay support checks packets against the relayer's local time. This is inconsistent with the IBC handlers implementation that checks against the block time of the latest on-chain block.

Version

v0.10.0

Acceptance Criteria

The connection delay logic uses the target chain's latest block time.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 added A: bug Admin: something isn't working I: logic Internal: related to the relaying logic labels Jan 14, 2022
@adizere adizere added this to the v1.0.0 milestone Feb 1, 2022
@adizere adizere mentioned this issue Feb 2, 2022
Closed
8 tasks
@adizere adizere mentioned this issue Feb 14, 2022
Closed
5 tasks
@romac romac modified the milestones: v1.0.0, v0.12.1 Feb 14, 2022
@romac romac added modules and removed modules labels Feb 14, 2022
@adizere adizere added the P-high label Feb 22, 2022
@hu55a1n1 hu55a1n1 mentioned this issue Feb 23, 2022
Merged
6 tasks
@adizere adizere moved this to Needs Triage in IBC-rs: the road to v1 Feb 24, 2022
@adizere adizere moved this from Backlog to Needs PR in IBC-rs: the road to v1 Feb 25, 2022
@hu55a1n1 hu55a1n1 moved this from Needs PR to Needs Review in IBC-rs: the road to v1 Mar 20, 2022
@adizere adizere modified the milestones: v0.13.0, v0.14.0 Mar 24, 2022
Repository owner moved this from Needs Review to Closed in IBC-rs: the road to v1 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hu55a1n1 hu55a1n1

Labels
A: bug Admin: something isn't working I: logic Internal: related to the relaying logic
Projects
No open projects
IBC-rs: the road to v1
Status: Closed
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

Fix the connection delay logic to use the header update block time informalsystems/hermes
3 participants
@romac @adizere @hu55a1n1