Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes should register for IBC events only #1534

Closed
5 tasks
ancazamfir opened this issue Nov 2, 2021 · 0 comments · Fixed by #1535
Closed
5 tasks

Hermes should register for IBC events only #1534

ancazamfir opened this issue Nov 2, 2021 · 0 comments · Fixed by #1535
Assignees
Labels
O: performance Objective: cause to improve performance
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer

Summary

hermes registers and gets all Tx events for all blocks. Instead hermes should register for IBC events only.
See more context in #1524

Problem Definition

Currently hermes gets all Tx events although it only processes the IBC events. When a block includes > 100 messages the client subscription may be closed if the events are not retrieved fast enough.

Proposal

To mitigate this problem hermes should register for IBC events only.

Acceptance Criteria

Significantly reduce the RPC error related to websocket client disconnects.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the v0.8.1 milestone Nov 3, 2021
@adizere adizere added the O: performance Objective: cause to improve performance label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: performance Objective: cause to improve performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants