You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the presence of errors, the current logs (below) do not look great and are difficult to parse and work with both for humans and programmatically. To improve their usefulness and legibility we should ensure that each log output is emitted as a single line.
Problem Definition
In the presence of errors, the logs emitted by Hermes are subpar for a long-running command-line tool, and are less than useful for operators, especially when working with the logs programmatically or when using tools like grep.
2021-10-27T22:00:13.861230Z ERROR ThreadId(27) [ibc-0] failed to collect events:
0: WebSocket driver failed
1:
1: 0: web socket error: failed to read from WebSocket connection
1: 1: WebSocket protocol error: Connection reset without closing handshake
1: Location:
1: /Users/coromac/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/flex-error-0.4.4/src/tracer_impl/eyre.rs:10
1: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
1: ⋮ 10 frames hidden ⋮
...
Proposal
When Hermes is not connected to an interactive terminal (ie. a tty), for example because the logs are streamed to a file or some other service that operators may be using, ensure errors are emitted on a single line and do not include a backtrace.
Acceptance Criteria
Errors in logs look like this when Hermes is not connected to a tty:
2021-10-27T22:01:37.228355Z ERROR ThreadId(27) [ibc-0] failed to collect events: WebSocket driver failed: web socket error: failed to read from WebSocket connection: WebSocket protocol error: Connection reset without closing handshake
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate milestone (priority) applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
romac
changed the title
Output errors on a single line if ANSI output is disabled
Output errors on a single line if backtraces are disabled
Nov 10, 2021
Crate
ibc-relayer-cli
Summary
In the presence of errors, the current logs (below) do not look great and are difficult to parse and work with both for humans and programmatically. To improve their usefulness and legibility we should ensure that each log output is emitted as a single line.
Problem Definition
In the presence of errors, the logs emitted by Hermes are subpar for a long-running command-line tool, and are less than useful for operators, especially when working with the logs programmatically or when using tools like
grep
.Proposal
When Hermes is not connected to an interactive terminal (ie. a tty), for example because the logs are streamed to a file or some other service that operators may be using, ensure errors are emitted on a single line and do not include a backtrace.
Acceptance Criteria
Errors in logs look like this when Hermes is not connected to a tty:
For Admin Use
The text was updated successfully, but these errors were encountered: