Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing debug fmt string for PendingTx #1488

Closed
5 tasks
Tracked by #1538
ancazamfir opened this issue Oct 25, 2021 · 0 comments · Fixed by #1843
Closed
5 tasks
Tracked by #1538

Confusing debug fmt string for PendingTx #1488

ancazamfir opened this issue Oct 25, 2021 · 0 comments · Fixed by #1843
Assignees
Labels
A: bug Admin: something isn't working A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer

Summary of Bug

The check for verifying pending transactions displays a flipped relay path making things confusing. When timeouts are involved it is even more confusing.

And example log:

...
Oct 25 16:26:50.334  INFO ThreadId(83) [injective-1:transfer/channel-2 -> band-laozi-testnet4] relay op. data of 7 msgs(s) to Destination (height 1-1639), delayed by: 4.637976501s [try 1/5]
...
Oct 25 16:26:51.682 DEBUG ThreadId(25) [band-laozi-testnet4] send_tx: broadcast_tx_sync: Response { code: Ok, data: Data([]), log: Log("[]"), hash: transaction::Hash(7098354FD825350999B8EA1C322A0AF3CB7BD7EDF0E38A83AA970D448D34A147) }
....
Oct 25 16:26:52.329 DEBUG ThreadId(25) [band-laozi-testnet4] send_tx: broadcast_tx_sync: Response { code: Ok, data: Data([]), log: Log("[]"), hash: transaction::Hash(83BCA91B8176BA16055E34757AD6689966587DD137CE0096F62C6DB0B05B1415) }
...
Oct 25 16:26:52.329  INFO ThreadId(83) [injective-1:transfer/channel-2 -> band-laozi-testnet4] success
Oct 25 16:26:52.329 TRACE ThreadId(83) [band-laozi-testnet4:transfer/channel-90 -> injective-1] trying to confirm TxHashes: count=2; 7098354FD825350999B8EA1C322A0AF3CB7BD7EDF0E38A83AA970D448D34A147; 83BCA91B8176BA16055E34757AD6689966587DD137CE0096F62C6DB0B05B1415 
Oct 25 16:26:52.425 TRACE ThreadId(83) [band-laozi-testnet4:transfer/channel-90 -> injective-1] transaction is not yet committed: TxHashes: count=2; 7098354FD825350999B8EA1C322A0AF3CB7BD7EDF0E38A83AA970D448D34A147; 83BCA91B8176BA16055E34757AD6689966587DD137CE0096F62C6DB0B05B1415 
Oct 25 16:26:52.425 TRACE ThreadId(83) [band-laozi-testnet4:transfer/channel-90 -> injective-1] total pending transactions left: 1
...

Version

master

Steps to Reproduce

Run hermes with tx_confirmation = true and check the logs.

Acceptance Criteria

The logs should show the same relay path for the worker thread, e.g. in the example above it should be clear we try to confirm a Tx that was sent to -> band-laozi-testnet4.

Oct 25 16:26:52.329 TRACE ThreadId(83) [injective-1:transfer/channel-2 -> band-laozi-testnet4] trying to confirm TxHashes: count=2; 7098354FD825350999B8EA1C322A0AF3CB7BD7EDF0E38A83AA970D448D34A147; 83BCA91B8176BA16055E34757AD6689966587DD137CE0096F62C6DB0B05B1415 

Or specify the chain where the Tx is expected to show up.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added this to the v0.8.3 milestone Nov 3, 2021
@adizere adizere added A: bug Admin: something isn't working O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Nov 3, 2021
@romac romac added the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Nov 12, 2021
@adizere adizere modified the milestones: v0.11.0, v0.11.1 Jan 25, 2022
@romac romac modified the milestones: v0.11.1, v0.12.0 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants