Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config trusting-period, when not specified, should be set to 2/3rds of the unbonding period #1133

Closed
5 tasks
ancazamfir opened this issue Jun 28, 2021 · 1 comment · Fixed by #1392 or #1441
Closed
5 tasks

Config trusting-period, when not specified, should be set to 2/3rds of the unbonding period #1133

ancazamfir opened this issue Jun 28, 2021 · 1 comment · Fixed by #1392 or #1441
Assignees
@hu55a1n1
Labels
I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
10.2021

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Jun 28, 2021 •
edited
Loading

Crate

relayer

Summary of Bug

The relayer configuration file includes trusting-period which defaults to 14days when not specified. Instead it should default to 2/3rd of the unbonding-period.

Version

Steps to Reproduce

Acceptance Criteria

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Aug 3, 2021
@adizere adizere added this to the 08.2021 milestone Aug 3, 2021
@adizere adizere modified the milestones: 08.2021, 09.2021 Sep 6, 2021
@ancazamfir ancazamfir changed the title Config trusting-period, when not specified, should be set to 1/3rd of the unbonding period Config trusting-period, when not specified, should be set to 2/3rd of the unbonding period Sep 21, 2021
@ancazamfir ancazamfir changed the title Config trusting-period, when not specified, should be set to 2/3rd of the unbonding period Config trusting-period, when not specified, should be set to 2/3rds of the unbonding period Sep 21, 2021
@adizere adizere modified the milestones: 09.2021, 10.2021 Sep 27, 2021
@hu55a1n1 hu55a1n1 self-assigned this Sep 27, 2021
@hu55a1n1 hu55a1n1 mentioned this issue Sep 27, 2021
Merged
5 tasks
@ancazamfir
Copy link
Collaborator Author

I tried running hermes create client with the repository config file with the trusting_period lines removed.
I get this error

The Hermes configuration file at path '/Users/ancaz/.hermes/config.toml' is invalid, reason: parse error: missing field `trusting_period` for key `chains` at line 36 column 1
Please see the example configuration for detailed information about the supported configuration options: https://github.com/informalsystems/ibc-rs/blob/master/config.toml

@ancazamfir ancazamfir reopened this Oct 8, 2021
@hu55a1n1 hu55a1n1 mentioned this issue Oct 8, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hu55a1n1 hu55a1n1

Labels
I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Milestone
10.2021
3 participants
@adizere @ancazamfir @hu55a1n1