hermes keys add
and hermes keys restore
are redundant
#1075
Labels
A: good-first-issue
Admin: good for newcomers
I: CLI
Internal: related to the relayer's CLI
O: security
Objective: cause to enhance security and improve safety
O: usability
Objective: cause to improve the user experience (UX) and ease using the product
Milestone
Crate
relayer-cli
Summary
We could reduce the number of commands supported under
hermes keys
.Problem Definition
With the
--hd-path
command implemented for bothkeys add
andkeys restore
, the two commands essentially require the same parameters but in a different format. One requests the mnemonic from a file, the other from the stdin.It would simpler to only maintain one code base instead.
Proposal
a.) Merge the two commands into add that has both the
-f
and the-m
command. They are interchangeable but only one can be defined.b.) Come up with other solutions so there's only one code that supports adding/restoring keys.
Acceptance Criteria
Done: The process of adding/restoring keys is straightforward.
For Admin Use
The text was updated successfully, but these errors were encountered: