You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apart from that, next_consensus_state and prev_consensus_state - both cases, we are trying to find a partition point. Considering the keys are sorted, we may want to use partition_point.
The text was updated successfully, but these errors were encountered:
Bug in
next_consensus_state
The following comparison should be reversed.
basecoin-rs/basecoin/modules/src/ibc/client_contexts.rs
Lines 201 to 203 in 57f47f2
Refactor
prev_consensus_state
We can simplify the
prev_consensus_state
asnext_consensus_state
if we reverse the iterator here.basecoin-rs/basecoin/modules/src/ibc/client_contexts.rs
Line 233 in 57f47f2
ref impl in ibc-rs testkit.
Apart from that,
next_consensus_state
andprev_consensus_state
- both cases, we are trying to find a partition point. Considering the keys are sorted, we may want to use partition_point.The text was updated successfully, but these errors were encountered: