Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Login widget instead of login from CLI #5

Open
dmknght opened this issue Aug 26, 2020 · 4 comments
Open

Create Login widget instead of login from CLI #5

dmknght opened this issue Aug 26, 2020 · 4 comments

Comments

@dmknght
Copy link

dmknght commented Aug 26, 2020

  • Faraday GTK Client version: 1.0.1
  • Python version: 3.8.2-3
  • Operating System: Parrot 4.10

Description

By now the faraday-client --gui GUI has 2 problems:

  1. Needs type login cred from terminal
  2. If there is no workspace, it can't open GUI.

In my opinion, it is:

  1. Not very friendly for GUI only, which can be used by menu
  2. Run a terminal in background which is not really needed.
  3. Options like: host, port, cert file, workspace name can be done by GUI. (Armitage project is a good example)

What I suggest

  1. Create login widget which has
  • Address
  • Workspace name
  • Username and password
  • Ask user to use custom cert file, a file selection to load cert
  1. Support config file to parse from it so users don't have to type everything everytime (save everything except username and password?)
  2. Support login with no workspace?
@aenima-x
Copy link
Contributor

aenima-x commented Aug 26, 2020

You dont need to use the --gui parameter.
Is the default

You dont have que enter the credentials every time, there is in fact a "config file".
It only asks for credentials if there is no config file, or the session is expired.
Here you can see that it only ask me for credentials the first time
image

There is a widget for credentials, but in only works once you are in the UI.
For things like change to other user, or if the current session expired.
image

You can login with not workspace, it just ask you to create one.
There is no sense to use faraday-client with no workspace at all
image

@dmknght
Copy link
Author

dmknght commented Aug 27, 2020

Well thank you. It is a little bit weird because i didn't see that login widget or create workspace. Let me pull latest source code from github and try again.

@dmknght
Copy link
Author

dmknght commented Aug 27, 2020

Can the ask for username and password in cli first time move to GUI as same as session is expired?

@dmknght
Copy link
Author

dmknght commented Aug 27, 2020

Anyway instead of title Faraday login at URL I think it can be changed to an entry Login URL: and default URL can be empty or parsed from config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants