Snapshot and API bind addresses #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the data node specific routes under a common /data prefix so add new handler does require updates to the top level handler as well.
| log.Fatalf("snapshot server failed to listen on %s: %s", cmd.config.SnapshotAddr(), err) | ||
| } | ||
| log.Printf("snapshot server listening on %s", cmd.config.SnapshotAddr()) | ||
| log.Printf("snaphot server listening on %s", cmd.config.ClusterAddr()) |
|
+1, nice to see that top-level URL routing fixed up. |
|
One small typo in a log line, otherwise 👍 |
This removes the separate port listener and adds it as a route on the cluster port.
Now listens on the cluster port. Snapshots can still be disabled though.
The HTTP bind address/port config was not actually being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
/dataprefix to make the top-level handler less brittle./data/snapshot[snapshot].bind-addressand[snapshot].portconfig sections since it now uses the cluster bind address and port