Require parameter for query endpoint #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylanou
force-pushed
the
http-query-require-param
branch
from
39e9e27 to
4cb5fbb
Compare
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| ### Bugfixes | |||
| - [#1971](https://github.com/influxdb/influxdb/pull/1971): Fix leader id initialization. | |||
| - [#1975](https://github.com/influxdb/influxdb/pull/1975): Require parameter for query endpoint. | |||
There was a problem hiding this comment.
This should be a bit more precise. Which parameter after all? "Require 'q' parameter for query endpoint" perhaps?
| pretty := q.Get("pretty") == "true" | ||
|
|
||
| qp := strings.TrimSpace(q.Get("q")) |
There was a problem hiding this comment.
Because a user can send in a parameter of q=+ which is just a space which will result in the parser still returning ok. While not exactly the same error, the result is you really didn't give me a query parameter, so it needs to return an error.
|
Makes sense, 1 question. +1 |
|
|
toddboom
added a commit
that referenced
this pull request
Mar 16, 2015
Require parameter for query endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where if you issued a curl command like this and accidentally sent the wrong params (double encoded) and as a result, didn't send the
qparameter, the endpoint would return 200 ok with an empty json result, instead of an error:It now correctly returns this: