Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minus without space cannot work with num #768

Closed
wants to merge 1 commit into from
Closed

minus without space cannot work with num #768

wants to merge 1 commit into from

Conversation

jvshahid
Copy link
Contributor

influxdb 0.7.2
select a+b from c work ok
select a-b from c return nothing
select a - b from c work ok

@huhongbo huhongbo changed the title minus cannot work with num minus without space cannot work with num Jul 18, 2014
@jvshahid
Copy link
Contributor

Do you see anything in the logs ?

This patch isn't backward compatible since older version allowed the use
of table names with '-' without enclosing them. With this change, '-'
characters are disallowed completely unless they were enclosed in double
quotes. The parser can be made more complicated and be more context
aware to distinguish the use of the '-' character depending on the query
being parser, but I think the approach in this patch is simpler and
less confusing from the user's point of view.
@jvshahid
Copy link
Contributor

This change isn't backward compatible, see the commit message for more details.

@jvshahid jvshahid added this to the 0.8.0 milestone Aug 13, 2014
@jvshahid jvshahid modified the milestones: 0.8.0, Next release Aug 25, 2014
@pauldix
Copy link
Member

pauldix commented Sep 8, 2014

lgtm

@jvshahid jvshahid closed this in 39583a0 Sep 8, 2014
@jvshahid jvshahid deleted the fix-768 branch September 9, 2014 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants