Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statsd input can not process metric names with a colon in it #547

Closed
entertainyou opened this issue Jan 19, 2016 · 4 comments
Closed

Statsd input can not process metric names with a colon in it #547

entertainyou opened this issue Jan 19, 2016 · 4 comments
Labels
bug unexpected problem or unintended behavior

Comments

@entertainyou
Copy link
Contributor

An example foo,url=http://www.google.com:10|ms, I found no restriction on metric name in https://github.com/b/statsd_spec, and my output backend is influxdb, which can accept colon in metric name.

It would be great if telegraf can support colon in metric name

@sparrc sparrc added the bug unexpected problem or unintended behavior label Jan 19, 2016
@sparrc
Copy link
Contributor

sparrc commented Jan 19, 2016

good point, shouldn't be a hard fix

@sparrc
Copy link
Contributor

sparrc commented Jan 19, 2016

actually this isn't trivial because of #354, will have to do some checking on each ":" split if the resulting string looks like a statsd metric.

@sparrc sparrc changed the title Can not process metric names with a colon in it Statsd input can not process metric names with a colon in it Jan 20, 2016
@dgassaway
Copy link

Colons are not really valid in statsd format. The spec page says (although it's not a very tight definition):

Metrics are generally of the form metric_name:value|type

Metric names with colons will also be considered malformed input and dropped in the reference https://github.com/etsy/statsd server

@danielnelson
Copy link
Contributor

I think it is illegal as well, when this is resolved we can reconsider statsd/statsd#585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

4 participants