[Feature Proposal] [Input: Unbound DNS] Use tag to identify thread of thread-specific metrics

[voiprodrigo]

Proposal:

Create a separate unbound_threads measurement and place there all the thread-specific fields, tagged by the thread id. Probably as an option, as this would duplicate metrics in case of a configuration using a single thread.

Current behavior:

A single "unbound" measurement line is exported with fields for all threads, for example:

[...]
thread8_requestslist_avg
thread9_requestslist_avg
[...]

Desired behavior:

A separate measurement "unbound_threads" with the thread-specific values, with a tag "thread" identifying the thread id (thread0 -> threadX)

unbound_threads,thread=8 requestslist_avg=0,num_cachemiss=7

Use case:

This would allow queries grouped by thread, enabling easier visualizations on top of the thread specific values.

[russorat]

@voiprodrigo thanks for the issue! We will consider this for a future release. If you have any interest in tackling this and submitting a PR, we'd be happy to review.

[voiprodrigo]

@russorat I might, as initiation to Go, I have never touched it before. Glad to see the request validated, that was the first step.

_{Sent with GitHawk}

[voiprodrigo]

Hello,

I think I've got this pretty much done, except the tests fail. Telegraf itself does work as expected, as far as I can tell. I'm probably misunderstanding the asserts.

Can someone take a look at https://github.com/voiprodrigo/telegraf/blob/FP-3959-Unbound/plugins/inputs/unbound/unbound_test.go ?

Thanks.

[voiprodrigo]

I was not passing a required boolean for the new test function.

I submitted PR #3969 @russorat

[russorat]

@voiprodrigo thanks for submitting a PR. we will take a look.