Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Wired memory on FreeBSD #3628

Closed
theory14 opened this issue Dec 28, 2017 · 0 comments · Fixed by #3632
Closed

Report Wired memory on FreeBSD #3628

theory14 opened this issue Dec 28, 2017 · 0 comments · Fixed by #3632
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@theory14
Copy link

Feature Request

One of the typically reported memory usage classifications on FreeBSD is "wired memory". See https://wiki.freebsd.org/Memory for info on memory classifications. Telegraf does not currently report this value though gopsutil does gather it.

Proposal:

Update telegraf to report wired memory on FreeBSD. The data is already gathered by gopsutil and from what I can tell, only a single line of telegraf code is needed to expose this data.

I tested this briefly by adding:

"wired": vm.Wired,

to the fields map in the Gather function in plugins/inputs/system/memory.go and it worked fine on a very quick inspection.

Current behavior:

Wired memory is not reported by telegraf.

Desired behavior:

Wired memory to be reported by telegraf.

Use case: [Why is this important (helps with prioritizing requests)]

Providing a complete view of memory usage on FreeBSD machines. This appears (to me at least) to be a simple one line update, so I hope the level of effort to include is minimal.

@danielnelson danielnelson added this to the 1.6.0 milestone Jan 3, 2018
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jan 3, 2018
@danielnelson danielnelson added feature request Requests for new plugin and for new features to existing plugins and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants