Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagpass with a list doesn't trigger error and just matches everything #16398

Open
knollet opened this issue Jan 14, 2025 · 0 comments
Open

Tagpass with a list doesn't trigger error and just matches everything #16398

knollet opened this issue Jan 14, 2025 · 0 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@knollet
Copy link
Contributor

knollet commented Jan 14, 2025

Use Case

People work sloppily and try to match metrics with a tagpass = ["mymarkertag"] when the correct version would be tagpass = { "markertag" = ["mymarkertag"] } or similar.
Telegraf doesn't error out, though, and processors and outputs still process and put out the affected metrics because no working tagpass means matching every metric.

But it also matches metrics it shouldn't match and those end up in databases where they shouldn't end up.

Expected behavior

Error out with a config syntax error because tagpass expects a dictionary

Actual behavior

No erroring out and just matching everything leading to metrics in places where they don't belong.

Additional info

No response

@knollet knollet added the feature request Requests for new plugin and for new features to existing plugins label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

1 participant