-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnmi plugin: Got empty metric-name for response on Juniper MX204 #12831
Comments
I am seeing the same issue as well on vMX: 2023-03-13T10:24:05Z D! [inputs.gnmi] Internal alias mapping: map[/interfaces/interface/state/counters:gnmi_interface_counters /lldp/interfaces/interface/state/counters:gnmi_lldp_counters openconfig-interfaces:/interfaces/interface/state/counters:gnmi_interface_counters openconfig-lldp:/lldp/interfaces/interface/state/counters:gnmi_lldp_counters] [[inputs.gnmi.subscription]] [[inputs.gnmi.subscription]] |
Could this be cosmetic? After doing a bit more testing - i can see all the stats for both inputs in the database - so looks like im not missing any telemetry info.
/components
gnmi_interface_counters,host=ubuntusrv,name=ge-0/0/4,path=/interfaces/interface,source=x.x.x.x |
@taitcodes it might be that you set the metric name later in your processing and then it will not be an issue. However, usually the metric should have the name you give via |
@srebhan Do you need any additional info from my side? |
Did I miss it or did you post your full GNMI section that was requested? |
Sorry it was unclear from the message who needed to provide the the full config, anyway, this is mine:
|
@protonmarco I cannot reproduce the issue with v1.26.2 or latest master. Can you please check if v1.26.2 fixes the issue for you!? [[inputs.gnmi.subscription]]
name = "interfaces-state"
origin = "openconfig-interfaces"
path = "/interfaces/interface/state"
subscription_mode = "sample"
sample_interval = "10s" |
I tested v1.26.2 and I'm still seeing that kind of messages for different interfaces |
@protonmarco can you please post the "empty name" warning (especially the data in there) and the corresponding config for me to reproduce the issue!? |
The config didn't change from the one above, this is the content of the message:
|
@protonmarco FYI: I can reproduce the issue now with latest master... Working on a fix... |
@protonmarco something is strange with your responses... If you look at the response you sent above it contains {
"path": {
"elem": [
{
"name": "init-time"
}
]
},
"val": {
"uintVal": "1668673227"
}
}, under the prefix |
I have opened a case with Juniper to understand this better, let's keep this on hold. |
I got a response and that's due to the fact that Juniper augments OpenConfig telemetry with custom fields. We can see here where the init-time field comes from. |
In this case, we do not have any information on how to name the metric. The best would be to add [inputs.gnmi.aliases]
metric_name_you_want = "/init-time" to your config... |
Hi @protonmarco , I'm also using Telegraf to connect to Juniper devices and I'm also having a similar issue trying to pull memory sensor data using the Would you be able to please advise what this config does for you in Telegraf:
Is it taking the description field:value and storing it as a tag inside of the "interface" measurement? But where did you define "interface" as the measurement name? |
@srebhan thanks for the tip, I think I'll leave it as it is as I don't need that kind of metric. @mohsin106 I wouldn't be surprised to see the same also on other paths. tbh it's unclear to me why Juniper sends out a metric for |
@protonmarco reading this issue again I wonder if it is solved or not!? :-) |
@mohsin106 let's discuss your issue in #13052... |
@srebhan yes we can close this one :) |
@srebhan , i'm seeing a very similar issue to what @protonmarco was seeing with Juniper. I cannot figure out how to use This is the error I'm getting:
I tried doing this:
But that didn't help and nothing was being processed. When I used the
Can this be because we're getting spurious data from the vendor? |
@mohsin106 could you please open another bug-report with the data of your post? Please ping me there and I'll take a look. It would also be interesting to know which Juniper model this is... |
@mohsin106 in #15278 I added a test-case with your data above and the metrics are correctly labeled even without a |
I am using telegraf:1.29.3 Also, this data is not with Juniper device it is with Ciena transport device. Can you plz share the GNMI config you used so I can test it on my side? |
It's basically your config see the file in the PR. Can you please open a new issue so we can track what's going on instead appending to an old one!?! |
Relevant telegraf.conf
Logs from Telegraf
System info
Telegraf 1.25.3, Juniper MX204 21.2R3
Docker
No response
Steps to reproduce
Expected behavior
No such log messages.
Actual behavior
Getting empty metric-name for response.
Additional info
I wasn't able to understand from which of the two paths the message was coming from, so I pasted them both.
As I got different logs of "empty metric-name" in other Juniper platforms, please let me know if I can group them in single tickets.
I'm available in case we need further tests.
The text was updated successfully, but these errors were encountered: