Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build against master currently fails with invalid dependencies #10040

Closed
johnseekins opened this issue Nov 1, 2021 · 8 comments
Closed

build against master currently fails with invalid dependencies #10040

johnseekins opened this issue Nov 1, 2021 · 8 comments
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis bug unexpected problem or unintended behavior

Comments

@johnseekins
Copy link
Contributor

Relevent telegraf.conf

None

System info

master, Fedora 34, git pull on 2021-11-01

Docker

No response

Steps to reproduce

  1. Clone repo locally
  2. run make test
  3. See the following:
make test
go test -short -race ./...
go: github.com/harlow/[email protected]: invalid version: unknown revision 5a873d6e9fec

Expected behavior

Tests actually run

Actual behavior

Tests fail because go.mod has a requirement for a version of kinesis-consumer that doesn't seem to exist. The last release of harlow/kinesis-consumer is 0.3.5: https://github.com/harlow/kinesis-consumer/releases

Additional info

No response

@johnseekins johnseekins added the bug unexpected problem or unintended behavior label Nov 1, 2021
@telegraf-tiger telegraf-tiger bot added the area/aws AWS plugins including cloudwatch, ecs, kinesis label Nov 1, 2021
@powersj
Copy link
Contributor

powersj commented Nov 3, 2021

Hi,

I set up a fresh checkout of telegraf on my system and was unable to reproduce it. Are you still seeing this?

ubuntu@nexus:~/telegraf$ make test
go test -short -race ./...
...
go: downloading github.com/harlow/kinesis-consumer v0.3.6-0.20210911031324-5a873d6e9fec

Thanks!

@johnseekins
Copy link
Contributor Author

I am still seeing this, yes. Even with another git pull. Doesn't telegraf require some strange GO_PROXY setting that I always forget about?
Right!

export GOPROXY=https://proxy.golang.org,direct
export GOSUMDB=sum.golang.org

That fixes it.

@johnseekins
Copy link
Contributor Author

Actually, that exposes another issue for me:

verifying [email protected]: checksum mismatch
	downloaded: h1:mRTLdljvxJNXPMMO9RSxf0PANDAqu/Tz+I6Dt6OjB28=
	go.sum:     h1:y4uFSAuOmeVhG3GCRa3/oH+ysePfO/+eGJNfd0Qa3d8=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

@johnseekins johnseekins reopened this Nov 4, 2021
@johnseekins
Copy link
Contributor Author

I think there's two problems I have here:

  1. My local build environment was trying to build with Golang 1.16, which telegraf no longer supports for building.
  2. The two proxy settings aren't defined for me, and I always forget about them...

I'll address #1 myself ('cause it's for sure my problem), but #2 is a really annoying thing. Seems like that could be documented better.

@always-waiting
Copy link

always-waiting commented Mar 14, 2022

@johnseekins I have same promblem. how did you fix this?

image

package github.com/harlow/kinesis-consumer does not have tag v0.3.6

and go version is 1.17.8

@johnseekins
Copy link
Contributor Author

I think your problem is different. As I noted above, I had two problems:

  1. my environment was configured wrong
  2. my build environment was a bit polluted.

I cleaned up my environment and things worked better.

@always-waiting
Copy link

always-waiting commented Mar 15, 2022

@johnseekins I found the package
kinesis-consumer, but there was't tag v0.3.6.

image

Is this normal?

@woorui
Copy link

woorui commented Jul 18, 2022

@always-waiting

I set GOPROXY from https://goproxy.io,direct to https://proxy.golang.org,direct and fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis bug unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

4 participants