From fa220dbf73bdb72867934050404809bf5814710e Mon Sep 17 00:00:00 2001 From: Palak Bhojani Date: Tue, 12 Feb 2019 10:01:12 -0800 Subject: [PATCH] Update Editable name to not allow empty string inline edit --- CHANGELOG.md | 3 ++- ui/src/shared/components/EditableName.tsx | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6964cf8566c..400f4ec83df 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,9 +3,10 @@ ### Features 1. [11809](https://github.com/influxdata/influxdb/pull/11809): Add the ability to name a scraper target 1. [11821](https://github.com/influxdata/influxdb/pull/11821): Display scraper name as the first and only updatable column in scrapers list +1. [11804](https://github.com/influxdata/influxdb/pull/11804): Add the ability to view runs for a task ### Bug Fixes - +1. [11819](https://github.com/influxdata/influxdb/pull/11819): Update the inline edit for resource names to guard for empty strings ### UI Improvements 1. [11764](https://github.com/influxdata/influxdb/pull/11764): Move the download telegraf config button to view config overlay diff --git a/ui/src/shared/components/EditableName.tsx b/ui/src/shared/components/EditableName.tsx index e3ed77a94e6..493da6aaa0b 100644 --- a/ui/src/shared/components/EditableName.tsx +++ b/ui/src/shared/components/EditableName.tsx @@ -113,6 +113,10 @@ class EditableName extends Component { const {workingName} = this.state if (e.key === 'Enter') { + if (!workingName) { + this.setState({isEditing: false, workingName: name}) + return + } await onUpdate(workingName) this.setState({isEditing: false}) }