Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Take in limiter.Fixed to support cancellation/timeouts #21600

Closed
danxmoran opened this issue Jun 3, 2021 · 0 comments · Fixed by #21621
Closed

Update Take in limiter.Fixed to support cancellation/timeouts #21600

danxmoran opened this issue Jun 3, 2021 · 0 comments · Fixed by #21621
Assignees
@danxmoran
Labels
area/storage area/2.x OSS 2.0 related issues and PRs kind/tech-debt Needs cleanup, will make the developer experience better

Comments

@danxmoran
Copy link
Contributor

#20814 reintroduced a concurrency limit to WAL encodings via a limiter.Fixed. There were concerns that we might deadlock/overload the DB if a large number of requests get stuck on the limiter at once. The risk of getting into that bad state seems smaller if the Take method supported cancellation/a timeout.

Since limiter.Fixed is defined within the influxdb repo, we should be able to extend it to support this new functionality.
@danxmoran danxmoran added area/storage kind/tech-debt Needs cleanup, will make the developer experience better area/2.x OSS 2.0 related issues and PRs labels Jun 3, 2021
@danxmoran danxmoran self-assigned this Jun 4, 2021
@danxmoran danxmoran mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danxmoran danxmoran

Labels
area/storage area/2.x OSS 2.0 related issues and PRs kind/tech-debt Needs cleanup, will make the developer experience better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add config parameters to toggle WAL concurrency and timeouts influxdata/influxdb
1 participant
@danxmoran