Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement safer filesystem level calls #11812

Closed
e-dard opened this issue Feb 12, 2019 · 2 comments
Closed

Implement safer filesystem level calls #11812

e-dard opened this issue Feb 12, 2019 · 2 comments
Assignees
Milestone

Comments

@e-dard
Copy link
Contributor

e-dard commented Feb 12, 2019

In a number of places we are using os.Rename for example. This command (on *nix) will happily overwrite files that might already exist at dest.

We should provide a higher level API that checks if files exist and allows us to assert that our invariants are true, e.g., that we're never renaming a file over another file if we don't intend to.

@e-dard e-dard modified the milestones: 1.5.5, 1.8 Feb 12, 2019
@e-dard e-dard self-assigned this Feb 12, 2019
@stale
Copy link

stale bot commented Jul 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 23, 2019
@e-dard
Copy link
Contributor Author

e-dard commented Jul 23, 2019

This will be closed via #14280

@stale stale bot removed the wontfix label Jul 23, 2019
@e-dard e-dard closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant