-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readOnly properties of create authorization endpoint should not be included in requests. #11714
Comments
@gshif would you add your request and response JSON structures? |
{"name":"u_1"}
{"name":"b","status:":"active"}
{
"orgID":"035c17edbd97a000",
"userID":"035c1869c297a000",
"permissions":[
{
"action":"write",
"resource":{"type":"buckets"}
}
]
}
{
"description": "",
"id": "035d0f7f1d17a000",
"links": {
"self": "/api/v2/authorizations/035d0f7f1d17a000",
"user": "/api/v2/users/035c1869c297a000"
},
"org": "b",
"orgID": "035c17edbd97a000",
"permissions": [
{
"action": "write",
"resource": {
"type": "buckets"
}
}
],
"status": "active",
"token": "d0LBLLShwT7fXBl9tolPz69peR8z_9gUnBkN12QHRK8ExOJyf_iCA85pAvQin-9F6Babhzczzj8KJrcqqro5WQ==",
"user": "u_1",
"userID": "035c1869c297a000"
}
|
If I create an authorization without passing a
|
We'll need to revert this PR: /cc @desa |
Closed in #11722 |
POST request body for the Authorization endpoint has following elements with
readOnly: true
properties:id
,token
,userID
,user
,org
andlinks
. Since these elements has readOnly set to true, then they should only be included inresponses
and not in therequests
, but I can passuserID
as part of a request and it won't be ignored (as well asuser
andorg
), i.e. the same userID that is passed to the request will be returned in the response.readOnly
properties fromuserID
,user
andorg
?orgID
andorg
. SinceorgID
element is already required, should these two elements,orgID
andorg
be removed?Reference: swagger.yml
The text was updated successfully, but these errors were encountered: