From 47358a480acc7760114979f582450c8bc90f285d Mon Sep 17 00:00:00 2001 From: Will Baker Date: Fri, 4 Jun 2021 14:40:56 -0400 Subject: [PATCH] chore: add comment and run make flags --- flags.yml | 4 ++++ kit/feature/list.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/flags.yml b/flags.yml index e1be70f45ce..2ed35961be1 100644 --- a/flags.yml +++ b/flags.yml @@ -63,6 +63,10 @@ lifetime: temporary expose: true +# This notebooksApi flag only controls the specific API calls that the frontend uses, +# not if the notebooks button is enabled on the sidebar. The notebooks flag (above) controls +# the display of the notebooks button on the sidebar. The notebooksAPI flag should be set to true +# to ensure the UI sends requests that the OSS backend can handle. - name: Notebooks Service API description: Enable the Equivalent notebooksd Service API key: notebooksApi diff --git a/kit/feature/list.go b/kit/feature/list.go index b8db29945ba..d8dafb077d3 100644 --- a/kit/feature/list.go +++ b/kit/feature/list.go @@ -90,7 +90,7 @@ var notebooks = MakeBoolFlag( "Notebooks", "notebooks", "Monitoring Team", - true, + false, Temporary, true, )