View flux editor in the CEO #4311
Conversation
| sources, | ||
| services, | ||
| meRole, | ||
| dashboard, | ||
| links: links.flux, |
There was a problem hiding this comment.
since these links are specific to flux, how do you feel about naming it something more specific like fluxLinks?
| script={script} | ||
| status={status} | ||
| notify={notify} | ||
| context={this.getContext} |
There was a problem hiding this comment.
why are you passing context in as both a context provider and a prop?
AlirieGray
force-pushed
the
flux/flux-editor-ceo
branch
from
7bc86cd to
a09a391
Compare
AlirieGray
force-pushed
the
flux/flux-editor-ceo
branch
2 times, most recently
from
4b9b15c to
15cf1e8
Compare
| @@ -40,7 +40,7 @@ const SourceSelector: SFC<Props> = ({ | |||
| sources={sources} | |||
| allowInfluxQL={true} | |||
| // TODO: when flux is added into CEO/DE, change to true | |||
| allowFlux={false} | |||
| allowFlux={process.env.NODE_ENV === 'development' ? true : false} | |||
There was a problem hiding this comment.
when will this be removed?
There was a problem hiding this comment.
Probably when the TimeMachine w/ Flux is added to the Data Explorer page. I believe @ischolten is working on that rn
|
|
||
| const funcNode = ( | ||
| <FuncNode | ||
| key={i} |
There was a problem hiding this comment.
since funcs have unique id's would you consider using those to uniquely key mapped items- instead of using their index? Using array index to generate keys is an anti pattern because react can't tell that things need to be updated if they change their order
| body: Body[] | ||
| service: Service | ||
| context: Context |
There was a problem hiding this comment.
if you are going to pass context down as props, could you name which context it is as well? maybe fluxContext.
| onDeleteBody={onDeleteBody} | ||
| isLastBody={this.isLastBody(i)} | ||
| declarationsFromBody={this.declarationsFromBody} |
There was a problem hiding this comment.
Is this watts???? (he always re-orders things based on their length).
| script: '', | ||
| } | ||
|
|
||
| this.debouncedASTResponse = _.debounce(script => { |
AlirieGray
force-pushed
the
flux/flux-editor-ceo
branch
3 times, most recently
from
1d41999 to
f671c9d
Compare
AlirieGray
force-pushed
the
flux/flux-editor-ceo
branch
from
f671c9d to
3ee1597
Compare
Closes: https://github.com/influxdata/applications-team-issues/issues/3 and https://github.com/influxdata/applications-team-issues/issues/4
What was the problem?
Only InfluxQL queries could be created from the Cell Editor Overlay. Furthermore, there was some repetitiveness with shared/TimeMachine and flux/TimeMachine.
What was the solution?