Add timeSelectorDropdown to timeMachine #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
flux/time-selection-dropdown
branch
from
fa5ca94 to
ae0633f
Compare
mavarius
reviewed
Aug 27, 2018
| @@ -39,6 +47,13 @@ const TimeMachineControls: SFC<Props> = ({ | |||
| isDynamicSourceSelected={isDynamicSourceSelected} | |||
| onSelectDynamicSource={onSelectDynamicSource} | |||
| /> | |||
|
|
|||
| <div style={{padding: 15}}> | |||
There was a problem hiding this comment.
Try to avoid inline styles wherever possible unless we need to dynamically control them with javascript.
ischolten
force-pushed
the
flux/time-selection-dropdown
branch
from
ae0633f to
4110947
Compare
mavarius
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4141
Briefly describe your proposed changes:
Add time selector dropdown into time machine. Store state in redux.
The time selector will default to the time set for the dashboard. This time selector does not update the time for the entire dashboard.