Introduce Cell Notes & Note Cells #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires further input to make sure this is effective at its purpose.
Avoid overlap with associated cell whenever possible
desa
reviewed
Aug 21, 2018
There was a problem hiding this comment.
@jaredscheib will this have the html sanitizing stuff in it, or will that be another PR?
jaredscheib
force-pushed
the
feat/cell-notes
branch
from
a1565d1 to
7b55538
Compare
jaredscheib
force-pushed
the
feat/cell-notes
branch
from
7b55538 to
be0dee3
Compare
desa
approved these changes
Aug 21, 2018
Less likely to go undiscovered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4232
Closes #2445
Briefly describe your proposed changes:
Users can add an optional note to a cell via the CEO Visualization tab. They can specify whether to show the note when the cell's queries return no data or leave as a tooltip.
Users can set a cell to type
Notewhich simply displays the contents of the note in the cell. Notes support markdown