Notify when User adds, deletes, or clones a cell #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planning to use this in the future to visually distinguish from “Create” actions
ebb-tide
approved these changes
Apr 16, 2018
| ...defaultSuccessNotification, | ||
| icon: 'duplicate', | ||
| duration: 2200, | ||
| message: `Added "${name}" to dashboard.`, |
There was a problem hiding this comment.
name here is the name of to the original cell, maybe clone message should say Added "${name}(clone)" to dashboard. ? or Cloned "${name}" to dashboard.?
There was a problem hiding this comment.
The cloned cell already as (Clone) appended to the name at this point, so it seemed redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3197
Briefly describe your proposed changes:
Display notification when user adds, deletes, or clones a cell.
What was the problem?
In some cases the location for a new or cloned cell is below the visible area and it is unclear if the action succeeded
What was the solution?
Display a notification for cell actions (add/delete/clone) so there is more consistent system feedback