Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Y Axis Title from exceeding height of graph #3130

Merged
merged 3 commits into from
Apr 6, 2018

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 4, 2018

Closes #3061
Closes #3133

Briefly describe your proposed changes:
Limit Y Axis Title to the height of its associated graph

What was the problem?
When the title is much longer it overflows and overlaps with the cell title

What was the solution?
Truncate the Y Axis Title with ellipsis when it exceeds the height of its associated graph.
I also tried having the title wrap but that ended up looking more cluttered so I opted to truncate.
Truncating suggests to users that concise titles are optimal

screen shot 2018-04-04 at 2 27 21 pm

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Tried this and having it wrap text, and this was the superior option
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clear up the conflicts and this is good to merge!

@alexpaxton alexpaxton merged commit 483a0d9 into master Apr 6, 2018
@alexpaxton alexpaxton deleted the bugfix/y-axis-title branch April 6, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants