Add Ability to Clone Dashboards #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing was being passed in, also moved the closure to where the function is defined
ebb-tide
approved these changes
Mar 31, 2018
| @@ -3,6 +3,7 @@ | |||
| ### Features | |||
|
|
|||
| 1. [#2526](https://github.com/influxdata/chronograf/pull/2526): Add support for RS256/JWKS verification, support for id_token parsing (as in ADFS) | |||
| 1. [#3103](https://github.com/influxdata/chronograf/pull/3103): Add ability to clone dashboards | |||
There was a problem hiding this comment.
so. this isn't quite in the purview of a code review: but noticed that maybe subsequent clones could be numbered instead of adding clone ad infinitum? might be a pain to implement though.
There was a problem hiding this comment.
That is the expected behavior. I wasn't sure off the top of my head the best way to handle this, as you'd have to look at all the existing dashboard names then decide whether to add a number or not
There was a problem hiding this comment.
I think I'm going to handle this in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3102
The Problem
The Solution
Preview