Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip feature flag for table graphs #3080

Merged
merged 4 commits into from
Apr 2, 2018
Merged

Conversation

ebb-tide
Copy link
Contributor

@ebb-tide ebb-tide commented Mar 28, 2018

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #1686

The problem

We needed tables as a visualization option

The Solution

We have tables as a visualization option. !!!

Notes:

  • the 'precision' feature is in progress.
  • particularly curious about thoughts on the structure of cell. (see below for comments)
  • the relevant files are:
    ui/src/shared/components/TableGraph.js
    ui/src/dashboards/components/TableOptions.tsx
    and their children...
    ps. If you think of a better way to organize this PR, or for me to make this easier to review, please let me know. :)

@ebb-tide
Copy link
Contributor Author

ebb-tide commented Mar 29, 2018

Check http://localhost:8888/docs for up-to-date swagger docs on cell.
I'm thinking that we may have put more generalizable properties, that properly belong as a direct child of Cell in to thetableOptions- this is why I got a bit paralyzed by the next precision feature. Precision (pts after decimal) with which a particular series is displayed is a more general property that we may (and according to russ, will) be using for graph types other than table.

considering a separate series field to replace TableOptions.fieldNames

{....
series: [
{internalName:"", displayName:"", visible: "", precision:"" }
]}

TimeFormat also probably belongs somewhere else. Axes.timeFormat?

Copy link
Contributor

@lukevmorris lukevmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes here are 👍. I can review the content of your comments when I'm in the office this morning.

@ebb-tide ebb-tide merged commit c28cf22 into master Apr 2, 2018
@lukevmorris lukevmorris deleted the flip-table-graph-feature-flag branch April 2, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants