Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Table Graph Format #1686

Closed
cryptoquick opened this issue Jul 4, 2017 · 31 comments
Closed

Dashboard Table Graph Format #1686

cryptoquick opened this issue Jul 4, 2017 · 31 comments
Assignees
Milestone

Comments

@cryptoquick
Copy link
Contributor

@nathanielc asked about displaying data in a table format, and we don't currently support that as a graph type on the dashboard.

@nhaugo
Copy link
Contributor

nhaugo commented Jul 5, 2017

Dupe of #1031

@nhaugo nhaugo closed this as completed Jul 5, 2017
@jaredscheib
Copy link
Contributor

Not quite @nhaugo#1031 is about Data Explorer, whereas this one's about Dashboard. Re-opening for now (the other one was closed anyway).

@jaredscheib jaredscheib reopened this Aug 31, 2017
@nhaugo nhaugo added this to the 1.4.x milestone Aug 31, 2017
@botzill
Copy link

botzill commented Oct 26, 2017

Hey guys,

Any plans to add such graph in the future ?

@nhaugo
Copy link
Contributor

nhaugo commented Oct 26, 2017

@botzill yes, but it is not currently schedule for any particular release.

@nhaugo
Copy link
Contributor

nhaugo commented Nov 3, 2017

See also #2246

@russorat
Copy link
Contributor

customer feedback: this would be really useful for "Top N" tables that could be used for identify bad actors. For example, i have a list of the top apps/ips/services that are making requests and I can investigate apps that are making way too many.

@hasselrot
Copy link

Would be extremely useful!
Any updates on this?

@nhaugo
Copy link
Contributor

nhaugo commented Dec 13, 2017

Hi @hasselrot,
I don't can't give you an exact timing, but it is near the top of the list for 2018

@nhaugo nhaugo modified the milestones: 1.4.x, 1.4.2 Dec 29, 2017
@121watts
Copy link
Contributor

121watts commented Jan 9, 2018

this package might be useful https://github.com/bvaughn/react-virtualized

@alexpaxton alexpaxton self-assigned this Feb 8, 2018
@russorat
Copy link
Contributor

russorat commented Feb 9, 2018

Initial Requirements:

  • A user shall be able to select to display their data as a table
  • A user shall be able to show or hide columns in the table
  • A user shall be able to sort table by any column
  • A user shall be able to override the name of each column
  • A user shall be able to correlate rows of the table with data from other graphs on the dash
  • A user shall be able to format the displayed timestamp
  • A user shall be able to set threshold values similar to single stat and change the color of the text or background

@alexpaxton
Copy link
Contributor

alexpaxton commented Feb 13, 2018

table-graph-design--v2.pdf

Included all the relevant details I can think of in here
I can handle styling next week

@alexpaxton
Copy link
Contributor

table-graph-design--v3.pdf

@evo7master
Copy link

We often need to compare two datasets at the same point in time, so it
would be exceptionally useful to not mandate time series on one axis , but to allow comparison of multiple measurements at the same point in time in a matrix, see example below:

screen shot 2018-02-20 at 12 08 16 pm

@russorat
Copy link
Contributor

thanks @evo7master ! we will see what we can do to tackle that use case.

@nhaugo nhaugo modified the milestones: 1.4.2, 1.4.3 Feb 24, 2018
@russorat
Copy link
Contributor

after looking at this, i've asked @alexpaxton to look into a simple way to format numbers in the table.

@russorat
Copy link
Contributor

also, eventually, we may be able to use influxql functions for this: influxdata/influxdb#9625 influxdata/influxdb#9626 influxdata/influxdb#9627 influxdata/influxdb#9628

@alexpaxton
Copy link
Contributor

screen shot 2018-03-23 at 12 43 19 pm

The UI for number formatting would be super simple (at least for this initial release)
The input would be type="number" to prevent users inputting decimals or non-numerical characters. You can also enforce a max/min from the HTML itself.

This input would either truncate the value or add 0s to the end depending on the value

I'm also thinking that we should right-align cells with numerical data to ensure the decimal point is vertically aligned within each column. I arbitrarily put 3 as a reasonable default for decimal places to show.

I think in the future we'll move towards scoping some of these options (thresholds, decimal places, suffix/prefix) by column instead of applying to the whole table

@russorat
Copy link
Contributor

I think that makes sense

@russorat
Copy link
Contributor

russorat commented Apr 2, 2018

  • headers slightly off due to vertical scroll bar

image

@russorat
Copy link
Contributor

russorat commented Apr 3, 2018

  • Need a way to reorder columns in the table (@ebb-tide)
  • Need a way to adjust the size of the columns. Sometimes they are really wide even if the data isn't (@ischolten)
  • Group by data should appear as a column duplicated for each row. This would allow you to use queries like select host, usage_user from "telegraf"."autogen"."cpu" group by host limit 1 and get a table with two columns: host and usage_user. Ask @ebb-tide for examples spreadsheet (@ebb-tide )
  • In Thresholds, the default should always be the normal display of data (black with blue text). Only items that hit a threshold should have the text or background changed. ( FYI @alexpaxton )
  • don't apply threshold values to the time column (@ebb-tide )

@micw
Copy link

micw commented Apr 4, 2018

Great work! Will there be an initial version available in 1.4.4?

@russorat
Copy link
Contributor

russorat commented Apr 25, 2018

feedback from demo:

  • see if there is a way to fix the ugly scroll bars on firefox

@russorat
Copy link
Contributor

Found this issue with table graphs. When jumping to the CEO, the query and visualization jumps back to the old mode.

kapture 2018-04-27 at 12 41 01

@russorat
Copy link
Contributor

russorat commented May 1, 2018

  • need to fix the render of subqueries: select sum("rate") from (SELECT difference("usage_user") AS "rate" FROM "kube-infra"."autogen"."cpu" WHERE time > :dashboardTime: GROUP BY *) WHERE "rate" > 0 GROUP BY cpu

@russorat
Copy link
Contributor

russorat commented May 3, 2018

Final few requests after using this for a little bit:

  • number values in the table should be right aligned, all other values should be left aligned. In future releases, we may allow this to be configurable by columns.
  • Do not highlight text values with thresholds. we may add a feature later specifically for non-numerical values
  • when time column is hidden, stop syncing the scroll with other graphs.

@russorat
Copy link
Contributor

russorat commented May 4, 2018

  • left align number is being covered by the scroll bar. Could we shift it to the left a little bit?
    image

  • double clicking on a frozen left column highlights the entire column (or multiple rows). Is there a way to get it to highlight a single value? Not sure if it's OS and browser specific or some css thingy.

kapture 2018-05-03 at 17 10 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests