-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Download
trait for Artifact
#3589
[Merged by Bors] - feat: Download
trait for Artifact
#3589
Conversation
fc4462e
to
6c5547a
Compare
...Improving to use path over passing file to get shasum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. LGTM
@digikata @sehz, looks like these tests: Initializes a tracing subscriber here: fluvio/crates/fluvio-hub-util/src/package.rs Line 620 in ad3e78f
Which conflicts with: #[test]
#test_attributes
fn #out_fn_iden() {
::fluvio_future::subscriber::init_logger(); // This subscriber
#input
let ft = async {
#name().await;
};
::fluvio_future::task::run_block_on(ft);
} Which is expanded by I don't see a way to avoid that |
Switch package.rs test util function to try_init? |
Removing them from the pkg test for now. Test code should not initialize the logger explicitly. We can add a non-Sync version in the fluvio future later |
bors r+ |
Build failed: |
bors retry |
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Download
trait for Artifact
Download
trait for Artifact
Introduces download logic for
Artifact
resource in the Hub Util API.Download logic is introduced through the
Download
trait which allow for decouplingfrom the type definition.