Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Download trait for Artifact #3589

Conversation

EstebanBorai
Copy link
Contributor

Introduces download logic for Artifact resource in the Hub Util API.

Download logic is introduced through the Download trait which allow for decoupling
from the type definition.

@EstebanBorai EstebanBorai requested review from digikata and sehz October 6, 2023 23:18
@EstebanBorai EstebanBorai force-pushed the feat/hub-fvm-artifact-download branch from fc4462e to 6c5547a Compare October 6, 2023 23:25
@EstebanBorai
Copy link
Contributor Author

...Improving to use path over passing file to get shasum

crates/fluvio-hub-util/src/fvm/api/client.rs Outdated Show resolved Hide resolved
crates/fluvio-hub-util/src/fvm/api/client.rs Outdated Show resolved Hide resolved
crates/fluvio-hub-util/src/fvm/api/client.rs Outdated Show resolved Hide resolved
crates/fluvio-hub-util/src/fvm/api/client.rs Outdated Show resolved Hide resolved
crates/fluvio-hub-util/src/fvm/api/client.rs Outdated Show resolved Hide resolved
crates/fluvio-hub-util/src/fvm/api/client.rs Outdated Show resolved Hide resolved
crates/fluvio-hub-util/src/fvm/api/download.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. LGTM

@EstebanBorai
Copy link
Contributor Author

@digikata @sehz, looks like these tests:

Initializes a tracing subscriber here:

Which conflicts with:
https://docs.rs/crate/fluvio-test-derive/0.1.1/source/src/lib.rs

        #[test]
        #test_attributes
        fn #out_fn_iden()  {

            ::fluvio_future::subscriber::init_logger(); // This subscriber

            #input

            let ft = async {
                #name().await;
            };

            
            ::fluvio_future::task::run_block_on(ft);

        }

Which is expanded by #[fluvio_future::test].

I don't see a way to avoid that subscriber::init_logger() from the macro itself, any suggestions?

@digikata
Copy link
Contributor

digikata commented Oct 7, 2023

@sehz
Copy link
Contributor

sehz commented Oct 7, 2023

Removing them from the pkg test for now. Test code should not initialize the logger explicitly. We can add a non-Sync version in the fluvio future later

@EstebanBorai
Copy link
Contributor Author

@sehz @digikata now tests are passing! I think we are good to move into the next step!

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 7, 2023
Introduces download logic for `Artifact` resource in the Hub Util API.

Download logic is introduced through the `Download` trait which allow for decoupling
from the type definition.
@bors
Copy link

bors bot commented Oct 7, 2023

Build failed:

@EstebanBorai
Copy link
Contributor Author

bors retry

bors bot pushed a commit that referenced this pull request Oct 7, 2023
Introduces download logic for `Artifact` resource in the Hub Util API.

Download logic is introduced through the `Download` trait which allow for decoupling
from the type definition.
@bors
Copy link

bors bot commented Oct 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Download trait for Artifact [Merged by Bors] - feat: Download trait for Artifact Oct 7, 2023
@bors bors bot closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants