Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: move cli dep to workspace #3582

Closed
wants to merge 5 commits into from

Conversation

sehz
Copy link
Contributor

@sehz sehz commented Oct 5, 2023

We still had a few dependencies in the CLI. Moving them to the workspace.
Fresh dep

@sehz sehz added this to the 0.11.0 milestone Oct 5, 2023
@sehz sehz force-pushed the sehz/workspace_dep branch from 7da0148 to 359017a Compare October 5, 2023 17:51
Copy link
Contributor

@matheus-consoli matheus-consoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sehz sehz force-pushed the sehz/workspace_dep branch from 359017a to 3f45798 Compare October 5, 2023 21:00
@sehz
Copy link
Contributor Author

sehz commented Oct 5, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 5, 2023
We still had a few dependencies in the CLI. Moving them to the workspace.
Fresh dep
@bors
Copy link

bors bot commented Oct 5, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: move cli dep to workspace [Merged by Bors] - chore: move cli dep to workspace Oct 5, 2023
@bors bors bot closed this Oct 5, 2023
@sehz sehz modified the milestones: 0.11.0, 0.10.16 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants