Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: add --truncate arg to fluvio consume and pretty print json output #3551

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: add --truncate arg to fluvio consume and pretty print json output #3551

wants to merge 2 commits into from

Conversation

matheus-consoli
Copy link
Contributor

Closes #3534
Fixes #3536

  • Pretty print json outputs when -O json is passed
  • Defaults to display the entire message, even when it's longer than the terminal width
  • Adds --truncate to opt-in back to old behavior

@matheus-consoli matheus-consoli force-pushed the consume-output-issues-3534-3536 branch from 9959b96 to 2fba392 Compare September 21, 2023 22:35
@ajhunyady ajhunyady requested review from sehz and digikata September 21, 2023 23:13
sehz
sehz approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehz sehz added this to the 0.10.15 milestone Sep 21, 2023
@sehz sehz added the CLI label Sep 21, 2023
@sehz
Copy link
Contributor

sehz commented Sep 22, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 22, 2023
@matheus-consoli
chore: add --truncate arg to fluvio consume and pretty print json…
3b25569 
… output (#3551)

Closes #3534
Fixes #3536 

- Pretty print json outputs when `-O json` is passed
- Defaults to display the entire message, even when it's longer than the terminal width
- Adds `--truncate` to opt-in back to old behavior
@bors
Copy link

bors bot commented Sep 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: add --truncate arg to fluvio consume and pretty print json output [Merged by Bors] - chore: add --truncate arg to fluvio consume and pretty print json output Sep 22, 2023
@bors bors bot closed this Sep 22, 2023
@matheus-consoli matheus-consoli deleted the consume-output-issues-3534-3536 branch September 22, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@digikata digikata Awaiting requested review from digikata

Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
0.10.15
2 participants
@matheus-consoli @sehz