-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Add capability to start SC on read-only mode. Read-only mode me… #3525
Conversation
6b1812e
to
c49846f
Compare
still in draft mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good. comments about using auth context rather than custom path
7d51395
to
328e3bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to add unit test
17aec21
to
8dc8ec2
Compare
de53478
to
a66f429
Compare
5d007c0
to
03064a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. just a minor nit on githubaction
862feb8
to
1f0603d
Compare
…ans, all write/update service endpoints are disabled and it runs without K8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work
bors r+ |
#3525) …ans, all write/update service endpoints are disabled. Also added smoke test that validates that a topic cannot be created in this mode
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
…ans, all write/update service endpoints are disabled.
Also added smoke test that validates that a topic cannot be created in this mode