Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: provides deprecation docs for warning #3488

Conversation

EstebanBorai
Copy link
Contributor

When attempting to build a SmartModule using Record instead of SmartModuleRecord the
current warning will also include link to documentation.

warning: use of deprecated method `fluvio_smartmodule::dataplane::smartmodule::SmartModuleInput::try_into_records`: use SmartModuleRecord instead. Read more here: https://www.fluvio.io/smartmodules/smdk/smartmodulerecord/.
 --> filter_map/src/lib.rs:5:1
  |
5 | #[smartmodule(filter_map)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default
  = note: this warning originates in the attribute macro `smartmodule` (in Nightly builds, run with -Z macro-backtrace for more info)

@EstebanBorai EstebanBorai requested review from digikata and sehz August 23, 2023 20:19
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, LGTM

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Aug 24, 2023
When attempting to build a SmartModule using `Record` instead of `SmartModuleRecord` the
current warning will also include link to documentation.

```
warning: use of deprecated method `fluvio_smartmodule::dataplane::smartmodule::SmartModuleInput::try_into_records`: use SmartModuleRecord instead. Read more here: https://www.fluvio.io/smartmodules/smdk/smartmodulerecord/.
 --> filter_map/src/lib.rs:5:1
  |
5 | #[smartmodule(filter_map)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default
  = note: this warning originates in the attribute macro `smartmodule` (in Nightly builds, run with -Z macro-backtrace for more info)

```
@bors
Copy link

bors bot commented Aug 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: provides deprecation docs for warning [Merged by Bors] - feat: provides deprecation docs for warning Aug 24, 2023
@bors bors bot closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants