Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Unify common dependencies #3442

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Unify common dependencies #3442

wants to merge 2 commits into from

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 3, 2023

Continuation of #3408

To the best of my knowledge, all common dependencies are now sharing the same workspace definition.

c410-f3r
c410-f3r commented Aug 3, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
@c410-f3r c410-f3r force-pushed the misc branch 2 times, most recently from c101a12 to 225aeb8 Compare August 7, 2023 17:56
@c410-f3r
Copy link
Contributor Author

c410-f3r commented Aug 7, 2023

Looks like https://github.com/infinyon/fluvio/actions/runs/5754781767/job/15601307131 was spurious but now https://github.com/infinyon/fluvio/actions/runs/5788343499/job/15687610521?pr=3442 is showing a version mismatch. Needs more investigation on my side.

@c410-f3r
Copy link
Contributor Author

@EstebanBorai CI looks OK now

EstebanBorai
EstebanBorai approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @c410-f3r! Nice work!

@EstebanBorai EstebanBorai requested a review from sehz August 10, 2023 22:22
sehz
sehz requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good except trybuild on a repo

crates/fluvio-test-case-derive/Cargo.toml Outdated Show resolved Hide resolved
sehz
sehz approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sehz
Copy link
Contributor

sehz commented Aug 14, 2023

bors r+

@c410-f3r
Copy link
Contributor Author

Thank you guys!

bors bot pushed a commit that referenced this pull request Aug 14, 2023
@c410-f3r
Unify common dependencies (#3442)
073e550 
Continuation of #3408

To the best of my knowledge, all common dependencies are now sharing the same workspace definition.
@bors
Copy link

bors bot commented Aug 14, 2023

Build failed:

@c410-f3r
Copy link
Contributor Author

Socket io Timed out: 60 secs waiting for response. API_KEY=1001, CorrelationId=5

Error looks spurious

@EstebanBorai
Copy link
Contributor

bors r+

@bors
Copy link

bors bot commented Aug 14, 2023

Merge conflict.

@morenol
Copy link
Contributor

morenol commented Aug 14, 2023 •
edited
Loading

@c410-f3r I just added a commit to solve conflicts with the changes of the last PR

bors r+

bors bot pushed a commit that referenced this pull request Aug 14, 2023
@c410-f3r @morenol
Unify common dependencies (#3442)
d9d9a62 
Continuation of #3408

To the best of my knowledge, all common dependencies are now sharing the same workspace definition.

Co-authored-by: morenol <[email protected]>
@bors
Copy link

bors bot commented Aug 14, 2023

Build failed:

@morenol
Copy link
Contributor

morenol commented Aug 14, 2023

bors retry

bors bot pushed a commit that referenced this pull request Aug 14, 2023
@c410-f3r @morenol
Unify common dependencies (#3442)
eb8d4f0 
Continuation of #3408

To the best of my knowledge, all common dependencies are now sharing the same workspace definition.

Co-authored-by: morenol <[email protected]>
@bors
Copy link

bors bot commented Aug 14, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Unify common dependencies [Merged by Bors] - Unify common dependencies Aug 14, 2023
@bors bors bot closed this Aug 14, 2023
@c410-f3r
Copy link
Contributor Author

Thank you @morenol !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EstebanBorai EstebanBorai EstebanBorai approved these changes

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c410-f3r @sehz @EstebanBorai @morenol