From d27b005ae67dac87e210d24da46774ab3902d6ce Mon Sep 17 00:00:00 2001 From: Esteban Borai Date: Fri, 12 May 2023 15:17:44 -0400 Subject: [PATCH] fix: pr review fixes --- crates/fluvio-cli/src/client/produce/mod.rs | 2 +- tests/cli/fluvio_smoke_tests/e2e-basic.bats | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/fluvio-cli/src/client/produce/mod.rs b/crates/fluvio-cli/src/client/produce/mod.rs index 226ee0a7721..8107497a926 100644 --- a/crates/fluvio-cli/src/client/produce/mod.rs +++ b/crates/fluvio-cli/src/client/produce/mod.rs @@ -91,7 +91,7 @@ mod cmd { /// Compression algorithm to use when sending records. /// Supported values: none, gzip, snappy, zstd and lz4. - #[clap(long)] + #[arg(long)] pub compression: Option, #[cfg(feature = "producer-file-io")] diff --git a/tests/cli/fluvio_smoke_tests/e2e-basic.bats b/tests/cli/fluvio_smoke_tests/e2e-basic.bats index efeb0f88a60..50505795a82 100644 --- a/tests/cli/fluvio_smoke_tests/e2e-basic.bats +++ b/tests/cli/fluvio_smoke_tests/e2e-basic.bats @@ -137,7 +137,7 @@ teardown_file() { run timeout 15s "$FLUVIO_BIN" topic create "$TOPIC_NAME_12" assert_success - if [[ "$FLUVIO_CLI_RELEASE_CHANNEL" != "stable" || "$FLUVIO_CLUSTER_RELEASE_CHANNEL" != "stable" ]]; then + if [[ "$FLUVIO_CLI_RELEASE_CHANNEL" != "stable" && "$FLUVIO_CLUSTER_RELEASE_CHANNEL" != "stable" ]]; then run timeout 15s "$FLUVIO_BIN" topic create "$TOPIC_NAME_13" --compression-type zstd assert_success fi @@ -158,7 +158,7 @@ teardown_file() { run bash -c 'echo -e "$LZ4_MESSAGE" | timeout 15s "$FLUVIO_BIN" produce "$TOPIC_NAME_6" --compression lz4' assert_success - if [[ "$FLUVIO_CLI_RELEASE_CHANNEL" != "stable" || "$FLUVIO_CLUSTER_RELEASE_CHANNEL" != "stable" ]]; then + if [[ "$FLUVIO_CLI_RELEASE_CHANNEL" != "stable" && "$FLUVIO_CLUSTER_RELEASE_CHANNEL" != "stable" ]]; then run bash -c 'echo -e "$ZSTD_MESSAGE" | timeout 15s "$FLUVIO_BIN" produce "$TOPIC_NAME_13" --compression zstd' assert_success fi