Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boilerplate): reworks some mst removal decorators #2832

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Oct 30, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

How to Test

  1. Observe failure via npx [email protected] new PizzaLint --overwrite --packager=npm --yes --debug --install-deps false --state none --remove-demo
  2. Checkout this branch
  3. Observe no failure via ignite/bin/ignite new PizzaLint --overwrite --packager=npm --yes --debug --install-deps false --state none --remove-demo where the first ignite directory is this GitHub project

Copy link
Contributor

@Jpoliachik Jpoliachik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix.
Still not a huge fan of how nitpicky the removal decorators can be, but I honestly don't know a better way to be able to support some of the code changes necessary for MST removal.

@frankcalise frankcalise merged commit 4c8d97a into master Oct 30, 2024
1 check passed
@frankcalise frankcalise deleted the fix/2829 branch October 30, 2024 21:46
infinitered-circleci pushed a commit that referenced this pull request Oct 30, 2024
## [10.0.4](v10.0.3...v10.0.4) (2024-10-30)

### Bug Fixes

* **boilerplate:** reworks some mst removal decorators ([#2832](#2832) by [@frankcalise](https://github.com/frankcalise)) ([4c8d97a](4c8d97a))
@infinitered-circleci
Copy link

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to initialize a new project using the ignite CLI Generated code has syntax errors
3 participants